Do it better

Author: spalmurray

src/background/dynamic_content_scripts.ts

@@ -55,7 +55,3 @@ export async function unregisterContentScriptIfExists(
 
   return true;
 }
-
-export async function setStorageValues(payload: any): Promise<void> {
-  await browser.storage.sync.set(payload);
-}

src/background/main.ts

@@ -4,15 +4,8 @@ import { MessageType } from "src/types";
 import { Codecov } from "src/service";
 import {
   registerContentScript,
-  setStorageValues,
   unregisterContentScriptIfExists,
 } from "./dynamic_content_scripts";
-import {
-  selfHostedCodecovApiToken,
-  selfHostedCodecovURLStorageKey,
-  selfHostedGitHubURLStorageKey,
-  useSelfHostedStorageKey,
-} from "src/constants";
 
 async function main(): Promise<void> {
   browser.runtime.onMessage.addListener(handleMessages);
@@ -38,8 +31,6 @@ async function handleMessages(message: {
       return registerContentScript(message.payload);
     case MessageType.UNREGISTER_CONTENT_SCRIPTS:
       return unregisterContentScriptIfExists(message.payload);
-    case MessageType.SET_STORAGE_VALUES:
-      return setStorageValues(message.payload);
   }
 }
 

src/popup/main.tsx

@@ -142,14 +142,11 @@ const Popup = () => {
       }
     }
 
-    await browser.runtime.sendMessage({
-      type: MessageType.SET_STORAGE_VALUES,
-      payload: {
-        [useSelfHostedStorageKey]: useSelfHosted,
-        [selfHostedCodecovURLStorageKey]: codecovUrl,
-        [selfHostedGitHubURLStorageKey]: githubUrl,
-        [selfHostedCodecovApiToken]: codecovApiToken,
-      },
+    await browser.storage.sync.set({
+      [useSelfHostedStorageKey]: useSelfHosted,
+      [selfHostedCodecovURLStorageKey]: codecovUrl,
+      [selfHostedGitHubURLStorageKey]: githubUrl,
+      [selfHostedCodecovApiToken]: codecovApiToken,
     });
 
     resetEphemeralState();

src/types.ts

@@ -43,5 +43,4 @@ export enum MessageType {
   FETCH_COMPONENTS_LIST = "fetch_components_list",
   REGISTER_CONTENT_SCRIPTS = "register_content_scripts",
   UNREGISTER_CONTENT_SCRIPTS = "unregister_content_scripts",
-  SET_STORAGE_VALUES = "set_storage_values",
 }