Adjust storage api usage for safari compatibility

Author: spalmurray

src/background/dynamic_content_scripts.ts

@@ -8,6 +8,7 @@ export async function registerContentScript(payload: any): Promise<boolean> {
   const { url } = payload;
 
   const tabs = await browser.tabs.query({ active: true, currentWindow: true });
+
   if (!tabs[0]?.url?.startsWith(url)) {
     return false;
   }
@@ -35,9 +36,15 @@ export async function registerContentScript(payload: any): Promise<boolean> {
 export async function unregisterContentScriptIfExists(
   payload: any
 ): Promise<boolean> {
-  const registrations = await browser.scripting.getRegisteredContentScripts({
-    ids: [dynamicContentScriptRegistrationId],
-  });
+  let registrations: browser.Scripting.RegisteredContentScript[];
+  try {
+    registrations = await browser.scripting.getRegisteredContentScripts({
+      ids: [dynamicContentScriptRegistrationId],
+    });
+  } catch (error) {
+    return true;
+  }
+
   if (registrations.length === 0) {
     return true;
   }
@@ -48,3 +55,7 @@ export async function unregisterContentScriptIfExists(
 
   return true;
 }
+
+export async function setStorageValues(payload: any): Promise<void> {
+  await browser.storage.sync.set(payload);
+}

src/background/main.ts

@@ -4,8 +4,15 @@ import { MessageType } from "src/types";
 import { Codecov } from "src/service";
 import {
   registerContentScript,
+  setStorageValues,
   unregisterContentScriptIfExists,
 } from "./dynamic_content_scripts";
+import {
+  selfHostedCodecovApiToken,
+  selfHostedCodecovURLStorageKey,
+  selfHostedGitHubURLStorageKey,
+  useSelfHostedStorageKey,
+} from "src/constants";
 
 async function main(): Promise<void> {
   browser.runtime.onMessage.addListener(handleMessages);
@@ -31,6 +38,8 @@ async function handleMessages(message: {
       return registerContentScript(message.payload);
     case MessageType.UNREGISTER_CONTENT_SCRIPTS:
       return unregisterContentScriptIfExists(message.payload);
+    case MessageType.SET_STORAGE_VALUES:
+      return setStorageValues(message.payload);
   }
 }
 

src/popup/main.tsx

@@ -1,4 +1,4 @@
-import React, { ChangeEvent, useEffect, useState } from "react";
+import React, { useEffect, useState } from "react";
 import { createRoot } from "react-dom/client";
 import browser from "webextension-polyfill";
 import clsx from "clsx";
@@ -142,11 +142,14 @@ const Popup = () => {
       }
     }
 
-    await browser.storage.sync.set({
-      [useSelfHostedStorageKey]: useSelfHosted,
-      [selfHostedCodecovURLStorageKey]: codecovUrl,
-      [selfHostedGitHubURLStorageKey]: githubUrl,
-      [selfHostedCodecovApiToken]: codecovApiToken,
+    await browser.runtime.sendMessage({
+      type: MessageType.SET_STORAGE_VALUES,
+      payload: {
+        [useSelfHostedStorageKey]: useSelfHosted,
+        [selfHostedCodecovURLStorageKey]: codecovUrl,
+        [selfHostedGitHubURLStorageKey]: githubUrl,
+        [selfHostedCodecovApiToken]: codecovApiToken,
+      },
     });
 
     resetEphemeralState();

src/service.ts

@@ -27,6 +27,7 @@ export class Codecov {
           selfHostedGitHubURLStorageKey,
           selfHostedCodecovApiToken,
         ]);
+
         const useSelfHosted = result[useSelfHostedStorageKey] || false;
         // self hosted not selected
         if (!useSelfHosted) {

src/types.ts

@@ -43,4 +43,5 @@ export enum MessageType {
   FETCH_COMPONENTS_LIST = "fetch_components_list",
   REGISTER_CONTENT_SCRIPTS = "register_content_scripts",
   UNREGISTER_CONTENT_SCRIPTS = "unregister_content_scripts",
+  SET_STORAGE_VALUES = "set_storage_values",
 }