Open
Conversation
Replaced all `authorizationKey` checks with a listener that performs the same check at a single point, right after a request is reveived. Off-loading such checks from the controllers keeps the code DRY and understandable.
- Added comments describing what the method does. - Improved the method code
Updated the method that handles the response with the contents of the JStree: - Used early-return if's - Moved the code that updates the tree to a dedicated method.
…when fetching last commit
In some cases there are no route parameters in the request and this should be handled in the AuthListener of the application, otherwise an exception will be raised
…anager-updates-no-html-encode
At the beta stage, travis-ci does not include preinstalled PHP environment so I am currently installing php from install scripts
dastergon
force-pushed
the
travis-trusty-beta
branch
from
69f662d to
877ec71
Compare
dastergon
force-pushed
the
travis-trusty-beta
branch
from
877ec71 to
ed011bc
Compare
Contributor
|
@dastergon Could we check if this is solved now from Travis' side? |
Contributor
Author
|
@spiliot the mysql issue is not yet resolved on their side and it won't be in the near future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Travis' team recently announced that they opened Ubuntu 14.04 as beta.
Since PR #6 is relevant to Ubuntu 14.04 compatibility, I enabled Ubuntu Trusty beta to run tests to its proper environment.
At beta stage, travis-ci does not include pre-installed PHP environment so I am currently installing php from install scripts
Contains PR #6