-
Notifications
You must be signed in to change notification settings - Fork 9
clean: remove enigma rules #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes the enigma-specific rules and related file checks, simplifying rule assembly to only repository and common rules. No new Codacy issues or complexity deltas were reported. Changes reduce surface area (removes filesystem checks and long guidance content) which lowers maintenance burden but may remove helpful user guidance if enigma support was previously expected.
Removing enigma rules and their file checks simplifies the code and avoids reading project-specific config (.codacy/codacy.yaml). Ensure there's a deliberate decision communicated in the PR description about dropping enigma support or moving guidance elsewhere (docs or separate generator) so users relying on that guidance are not surprised.
| name: 'Codacy Rules', | ||
| description: "Configuration for AI behavior when interacting with Codacy's MCP Server", | ||
| rules: [...repositoryRules, ...commonRules, ...enigmaRules].filter((rule) => !excludedScopes?.includes(rule.scope)), | ||
| rules: [...repositoryRules, ...commonRules].filter((rule) => !excludedScopes?.includes(rule.scope)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good simplification: previously complex logic that read .codacy/codacy.yaml and injected a large enigma guidance block has been removed. Confirm there are no downstream features or docs that still expect the enigma guidance or the enigma detection behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes enigma-related custom instructions and rules from the Codacy VS Code extension.
- Removes the logic that checks for enigma configuration in
.codacy/codacy.yaml - Eliminates the enigma-specific rule definitions that guided AI on how to create enigma rules
- Simplifies the rules array construction by removing the
enigmaRulesreference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove enigma custom instructions