Skip to content

feat: add lark-cli binary mirror support#1019

Merged
fengmk2 merged 3 commits intocnpm:masterfrom
MaxHuang22:feat/add_lark_cli_binary
Apr 1, 2026
Merged

feat: add lark-cli binary mirror support#1019
fengmk2 merged 3 commits intocnpm:masterfrom
MaxHuang22:feat/add_lark_cli_binary

Conversation

@MaxHuang22
Copy link
Copy Markdown
Contributor

@MaxHuang22 MaxHuang22 commented Mar 31, 2026

Summary

  • Add larksuite/cli (Lark CLI) to the binary mirror configuration using BinaryType.GitHub

Test plan

  • Verify binary sync works for lark-cli after deployment

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features

  • Added support for lark-cli binary tool, now available for installation from GitHub releases. The tool is configured and ready for use within the application's binary management system.

Add larksuite/cli GitHub binary to binaries config for mirroring Lark CLI releases.

Change-Id: I2209da8ba7186b22aed818e0dcf9c632746c74e5
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

Added a new binary entry lark-cli to the binaries configuration with GitHub-based distribution settings and metadata. This expands the available binary names and their configurations in the system.

Changes

Cohort / File(s) Summary
Binary Configuration
config/binaries.ts
Added lark-cli entry to binaries object with category, description, GitHub type, repository reference (larksuite/cli), and distribution URL, expanding BinaryName and BinaryConfigMap types.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • fengmk2
  • killagu

Poem

🐰 A new binary hops into the fold,
With Lark's CLI, our tools grow bold!
GitHub releases, a config so true,
TypeScript types expanded anew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding support for mirroring the lark-cli binary in the configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the lark-cli binary configuration to config/binaries.ts, specifying its category, description, repository, and distribution URL. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@config/binaries.ts`:
- Around line 975-981: The 'lark-cli' binary entry uses BinaryType.GitHub with
repo set to 'larksuite/cli', but that repository returns HTTP 403 so the
GithubBinary adapter will fail; either correct the repo value to the proper
public GitHub repo, or if the project is private change the binary configuration
away from BinaryType.GitHub (or add a private-repo handling strategy) and update
the 'lark-cli' object accordingly (look for the 'lark-cli' key, the
BinaryType.GitHub enum usage, and the repo/distUrl fields to modify).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 65aabd56-9351-4058-8bb9-6d52143c10df

📥 Commits

Reviewing files that changed from the base of the PR and between e82df3f and 1e9411e.

📒 Files selected for processing (1)
  • config/binaries.ts

@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Mar 31, 2026

@elrrrrrrr Need help with deployment

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.11%. Comparing base (1729848) to head (9db8eb1).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files         211      211           
  Lines        8603     8603           
  Branches     1699     1676   -23     
=======================================
  Hits         8097     8097           
  Misses        506      506           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaxHuang22
Copy link
Copy Markdown
Contributor Author

It seems CodeQL dynamic analysis doesn't trigger for config-only changes, so the required check stays pending. Could a maintainer help merge this? Thanks!

@MaxHuang22
Copy link
Copy Markdown
Contributor Author

@fengmk2 It seems CodeQL dynamic analysis doesn't trigger for config-only changes, so the required check stays pending. Could a maintainer help merge this? Thanks!

@fengmk2 fengmk2 merged commit f675552 into cnpm:master Apr 1, 2026
13 checks passed
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Apr 1, 2026

Now wait for @elrrrrrrr to finish the manual deployment 😃

fengmk2 pushed a commit that referenced this pull request Apr 1, 2026
[skip ci]

## 4.30.0 (2026-04-01)

* feat: add lark-cli binary mirror support (#1019) ([f675552](f675552)), closes [#1019](#1019)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

🎉 This PR is included in version 4.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Apr 1, 2026

@MaxHuang22 好了 https://registry.npmmirror.com/binary.html?path=lark-cli/v1.0.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants