feat: add lark-cli binary mirror support#1019
Conversation
Add larksuite/cli GitHub binary to binaries config for mirroring Lark CLI releases. Change-Id: I2209da8ba7186b22aed818e0dcf9c632746c74e5 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
📝 WalkthroughWalkthroughAdded a new binary entry Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@config/binaries.ts`:
- Around line 975-981: The 'lark-cli' binary entry uses BinaryType.GitHub with
repo set to 'larksuite/cli', but that repository returns HTTP 403 so the
GithubBinary adapter will fail; either correct the repo value to the proper
public GitHub repo, or if the project is private change the binary configuration
away from BinaryType.GitHub (or add a private-repo handling strategy) and update
the 'lark-cli' object accordingly (look for the 'lark-cli' key, the
BinaryType.GitHub enum usage, and the repo/distUrl fields to modify).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
@elrrrrrrr Need help with deployment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 211 211
Lines 8603 8603
Branches 1699 1676 -23
=======================================
Hits 8097 8097
Misses 506 506 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It seems CodeQL dynamic analysis doesn't trigger for config-only changes, so the required check stays pending. Could a maintainer help merge this? Thanks! |
|
@fengmk2 It seems CodeQL dynamic analysis doesn't trigger for config-only changes, so the required check stays pending. Could a maintainer help merge this? Thanks! |
|
Now wait for @elrrrrrrr to finish the manual deployment 😃 |
|
🎉 This PR is included in version 4.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
larksuite/cli(Lark CLI) to the binary mirror configuration usingBinaryType.GitHubTest plan
lark-cliafter deployment🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
lark-clibinary tool, now available for installation from GitHub releases. The tool is configured and ready for use within the application's binary management system.