Skip to content

ModuleAllocMonitor diff table updates#2717

Open
gartung wants to merge 17 commits intocms-sw:masterfrom
gartung:gartung-sort-table
Open

ModuleAllocMonitor diff table updates#2717
gartung wants to merge 17 commits intocms-sw:masterfrom
gartung:gartung-sort-table

Conversation

@gartung
Copy link
Copy Markdown
Member

@gartung gartung commented Apr 8, 2026

Makes the ModlueAllocMonitor diff table display only the column of the metric of interest for IB, PR or PR-IB.
Added search box for label, type and/or record and displays only the rows matching.
Adds a button to hide rows with a zero metric.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

cms-bot internal usage

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Apr 8, 2026

test parameters:

workflows_profiling = 18634.0
enable = profiling

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

Pull request #2717 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 8, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf579c/52554/summary.html
COMMIT: 24e21af
CMSSW: CMSSW_17_0_X_2026-04-08-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2717/52554/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4181709
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4181639
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

Pull request #2717 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

Pull request #2717 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf579c/52563/summary.html
COMMIT: e6f2379
CMSSW: CMSSW_17_0_X_2026-04-09-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2717/52563/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Apr 9, 2026

@makortel

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

Pull request #2717 was updated.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

Pull request #2717 was updated.

@gartung
Copy link
Copy Markdown
Member Author

gartung commented Apr 9, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 9, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf579c/52575/summary.html
COMMIT: a867c22
CMSSW: CMSSW_17_0_X_2026-04-09-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2717/52575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Copy Markdown
Contributor

@gartung , is this ready to go in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make columns in ModuleAllocMonitor diff table sortable

3 participants