Adding User and System Errors in FileErrorDetailsProvider #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
reviewed
Apr 15, 2025
| @Nullable ErrorContext errorContext, ErrorType errorType) { | ||
| String errorMessage = e.getMessage(); | ||
| return ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| errorMessage, String.format(ERROR_MESSAGE_FORMAT, errorContext.getPhase(), |
Collaborator
There was a problem hiding this comment.
errorContext can be null
psainics
reviewed
Apr 15, 2025
| List<Throwable> causalChain = Throwables.getCausalChain(e); | ||
| for (Throwable t : causalChain) { | ||
| if (t instanceof FileNotFoundException) { | ||
| return getProgramFailureException((FileNotFoundException) t, null, ErrorType.USER ); |
Collaborator
There was a problem hiding this comment.
why are we not passing error context here ?
AnkitCLI
force-pushed
the
addingKnownErrorsInFileErrorDetailsProvider
branch
from
0229703 to
848b7fe
Compare
AnkitCLI
force-pushed
the
addingKnownErrorsInFileErrorDetailsProvider
branch
from
848b7fe to
20f07d2
Compare
psainics
reviewed
Apr 22, 2025
| return getFileBasedExceptionDetails(e, errorContext); | ||
| } | ||
|
|
||
| public ProgramFailureException getFileBasedExceptionDetails(Exception e, ErrorContext errorContext) { |
Collaborator
There was a problem hiding this comment.
mark errorContext with @ Nullable
Collaborator
There was a problem hiding this comment.
also let the function accept error reason
AnkitCLI
force-pushed
the
addingKnownErrorsInFileErrorDetailsProvider
branch
7 times, most recently
from
623fa36 to
c93e883
Compare
AnkitCLI
force-pushed
the
addingKnownErrorsInFileErrorDetailsProvider
branch
from
c93e883 to
7124ab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.