Add restriction to only run for PRs with main as the target.#86
Merged
Add restriction to only run for PRs with main as the target.#86
Conversation
The intent is to facilitate the integration of external forks opening PRs.
|
wildintellect
approved these changes
Oct 27, 2023
Contributor
|
@zacharyDez can you explain the duplication of code across jobs in the workflow? also the json samples posted in the comments for success and fail appear to be identical - typo in copying? |
Collaborator
Author
|
Mishaps on my side, @wildintellect . Removed the duplicates and changed the example file in the comment! |
wildintellect
approved these changes
Oct 30, 2023
kylebarron
approved these changes
Oct 30, 2023
Contributor
kylebarron
left a comment
There was a problem hiding this comment.
I'm not familiar with the internals of github actions here, but looks fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Changed
For background information: See #74.
The preview action on external forks has failed because the pr-preview-action does not support preview on external forks. Also, it intends to refrain from supporting in the future.
The PR changes the preview action to only run on PRs to main.
How I tested it
For the changes to
ci.yml:pr-test-success.jsonpr-test-fail.jsonRun the workflows of the added job with: