Conversation
hsinn0
commented
Apr 6, 2026
hsinn0
commented
- Added FlywayPostgresTestStripConcurrentlyConfiguration to transform SQL scripts and remove CONCURRENTLY keyword from index DDL to prevent blocking during parallel test execution.
- Updated ParallelPostgresTestDataSourceConfiguration to use HikariCP with connection pool limits so as to avoid too many connection errors. Also set the timeouts to avoid indefinite waits.
- Also updated ParallelPostgresTestDataSourceConfiguration to use non-pooled database connection for 'create database'.
- AI-Assisted.
- Added FlywayPostgresTestStripConcurrentlyConfiguration to transform SQL scripts and remove CONCURRENTLY keyword from index DDL to prevent blocking during parallel test execution. - Updated ParallelPostgresTestDataSourceConfiguration to use HikariCP with connection pool limits so as to avoid too many connection errors. Also set the timeouts to avoid indefinite waits. - Also updated ParallelPostgresTestDataSourceConfiguration to use non-pooled database connection for 'create database'.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
| * For unit tests against PostgreSQL, strip `CONCURRENTLY` from index DDL in Flyway SQL migrations so | ||
| * migrations do not block on other connections (e.g. Flyway bookkeeping). Production migrations are | ||
| * unchanged on disk; only the in-memory script content is transformed. | ||
| * | ||
| * Every `*.sql` resource is wrapped (Flyway relative paths omit `db/migration/postgres/`); replacements are | ||
| * no-ops for scripts that do not use concurrent index DDL. |
There was a problem hiding this comment.
question: curious why this needed now, is it due to changes in Flyway or recent changes to the tests?
Is this related to flyway/flyway#3508 or flyway/flyway#3682
workaround suggests applying config flyway.postgresql.transactional.lock=false
There was a problem hiding this comment.
There was a problem hiding this comment.
question: curious why this needed now, is it due to changes in Flyway or recent changes to the tests?
The unit-tests-postgres-* jobs in Coucourse have been failing frequently with timeouts in the past, too. It seems that the timeout is just more frequent (or consistent) these days. I've never bothered looked into those CI timeouts, thinking they are flakes, as rerunning usually made the jobs pass.
For the matter of local run in my dev box, I do not regularly run the tests against postgresql database unless there is something postgresql-specific that need to be looked into. So no idea when the problem started to occur there. It is possible that this was caused by some changes in other dependencies such as hikari pool or hibernate.
Is this related to flyway/flyway#3508 or flyway/flyway#3682 workaround suggests applying config
flyway.postgresql.transactional.lock=false
Not sure if our current issue is related to those old flyway issues. Sounds similar, though. And yes, we are already setting transitionalLock to false (in FlywayMigrationStrategyTestConfig for tests).
As the goal is to prevent the hang for the tests and the issue is not to be expected to occur in production, and the change only affect test run with postgresql database, I think that just removing concurrently from the create/drop index statements for test only is the way to go.
There was a problem hiding this comment.
Yeah, the latest issue: flyway/flyway#3961
Seems like there's no other solutions yet.
dlinsley
left a comment
dlinsley
left a comment
There was a problem hiding this comment.
I was able to locally observe the PostgreSQL unit test hang locally. These changes do resolve the observed hang during tests allowing them to complete locally. Thanks for addressing the questions!
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
3 participants
