Recover from all refresh-token related errors by requesting a new token #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kehrlann
force-pushed
the
dgarnier/uaa-fix-failed-token
branch
from
a1f68a3 to
4d92cb4
Compare
- When the UAA throws an error other than HTTP 401, the refresh token flow fails, and can lead to irrecoverable errors where there application needs to be restarted. This changes ensure we are resilitent to all UAA errors. The downside is that we may not retry using a refresh token when it fails for an unrelated reason (eg HTTP 503), requesting access tokens more frequently. The impact should be extremely marginal. Signed-off-by: Daniel Garnier-Moiroux <[email protected]>
Kehrlann
force-pushed
the
dgarnier/uaa-fix-failed-token
branch
from
4d92cb4 to
aa18da5
Compare
pivotal-david-osullivan
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the UAA returns an HTTP 500 on refresh tokens because it is not valid anymore, the refresh token is not invalidated, stays in cache and is never "cleaned up".
This invalidates the refresh token, regardless of the UAA error.