Open
Conversation
jochenehret
requested changes
Jul 3, 2025
Contributor
jochenehret
left a comment
There was a problem hiding this comment.
Ops file works. But please add it to the list in ./operations/README.md.
|
|
||
| - type: replace | ||
| path: /instance_groups/name=api/jobs/name=cloud_controller_ng/properties/cc/buildpacks/fog_connection | ||
| error: "Please apply 'use-external-blobstore.yml' before applying 'use-s3-blobstore.yml'." |
Contributor
There was a problem hiding this comment.
I couldn't produce this error message. If I interpolate just this ops file with cf-deployment.yml, I get:
$ bosh interpolate -o ./operations/use-s3-custom-blobstore.yml cf-deployment.yml
Error 'operation [0] in ./operations/use-s3-custom-blobstore.yml failed': Expected to find a map key 'fog_connection' for path '/instance_groups/name=api/jobs/name=cloud_controller_ng/properties/cc/buildpacks/fog_connection' (found map keys: 'blobstore_type', 'webdav_config')
Exit code 1
Should we leave out this error message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
Implement a new ops-file,
operations/use-s3-custom-blobstore.yml, which adds an ops stanza that lets operators select and configure any S3-compatible blobstore (per the Fog S3 “other” settings in Cloud Foundry docs).What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
Alana wants to deploy CF on an environment with the private S3 compatible Blobstore (e.g. MinIO), but she needs to configure:
endpoint,aws_signature_versionandpath_stylePlease provide any contextual information.
operations/use-s3-custom-blobstore.ymlHas a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
We can now use
operations/use-s3-custom-blobstore.ymlto point any S3-compatible blobstore.Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
Verify settings in the rendered manifest (
bosh interpolate) match the provided values.What is the level of urgency for publishing this change?