Skip to content

update default suite timeout to 24h, as ginkgov2 changed it to 1h#1501

Merged
ctlong merged 1 commit intocloudfoundry:developfrom
geofffranks:suite-timeout-increase
Mar 21, 2025
Merged

update default suite timeout to 24h, as ginkgov2 changed it to 1h#1501
ctlong merged 1 commit intocloudfoundry:developfrom
geofffranks:suite-timeout-increase

Conversation

@geofffranks
Copy link
Copy Markdown
Contributor

Are you submitting this PR against the develop branch?

Yes i did it right this time!

What is this change about?

Ginkgo v2 changed the default suite timeout to 1hr which is too short for cats.

Please provide contextual information.

We recommend people set it to 24h in the readme

What version of cf-deployment have you run this cf-acceptance-test change against?

cats ref 562033f + cf-d v44.9.0

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

@ctlong
Copy link
Copy Markdown
Member

ctlong commented Mar 21, 2025

Worth noting that this is not a breaking change. I tested the ginkgo CLI and found that it will accept multiple --timeout flags, with the last such flag taking precedence. That means if specific scripts are using ./bin/test with a --timeout flag set, their value will take precedence over this setting of 24h. Effectively, this just changes the default from 1h to 24h.

@ctlong ctlong merged commit 2bd79f0 into cloudfoundry:develop Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants