Add scheduled metrics cleanup job #2654
Open
+305
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
This change adds automatic cleanup of stale metrics files in
/var/vcap/store/director/metricsto prevent disk space issues caused by accumulating Prometheus DirectFileStore binary files.Fixes #2623
Please provide contextual information.
Background:
Implementation:
ScheduledMetricsCleanupjob that runs daily at midnight UTCdirector.metrics_server.enabledis trueWhat tests have you run against this PR?
How should this change be described in bosh release notes?
New Feature: The metrics server now automatically cleans up stale metrics files older than the configured retention period (default: 7 days). This prevents disk space issues from accumulating metric binary files. Cleanup runs daily at midnight UTC and can be configured via
director.metrics_server.file_retention_daysanddirector.metrics_server.cleanup_scheduleproperties.Does this PR introduce a breaking change?
No. This is a new feature with safe defaults:
file_retention_daysto 0Tag your pair, your PM, and/or team!