Skip to content

fix: resolve directory imports for next/font shims #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoangnv170752 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve directory imports for next/font shims #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/vinext/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2104,6 +2104,16 @@ hydrate();
}
}

// Handle directory imports without extension (e.g., "next/font/local")
// Libraries like geist import "next/font/local" as a directory which
// Vite's ESM resolution rejects. Resolve through our shim map.
if (cleanId.startsWith("next/") && !cleanId.endsWith(".js")) {
Copy link
Contributor

@ask-bonk ask-bonk bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition cleanId.startsWith("next/") && !cleanId.endsWith(".js") matches every non-.js next/* import — not just "directory imports". For example, "next/navigation", "next/link", and "next/router" all match this condition.

This is benign (the shim map has those entries and the alias would resolve them anyway), but the comment "Handle directory imports without extension" is misleading — it implies only directory-like paths are caught, when in reality all next/* bare imports match.

Consider either:

  1. Making the comment accurate: "Fallback for any next/* bare import not resolved by resolve.alias"
  2. Or narrowing the condition if you truly only want directory-style subpath imports (e.g., paths with more than one / segment after next/)

if (nextShimMap[cleanId]) {
const shimPath = nextShimMap[cleanId];
return shimPath.endsWith(".js") ? shimPath : shimPath + ".js";
Copy link
Contributor

@ask-bonk ask-bonk bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is identical to what the .js handler above does (lines 2101-2103). Rather than duplicating, consider merging both blocks into a single handler as suggested in the review summary. This reduces code duplication and makes the intent clearer.

}
}

// Pages Router virtual modules
if (cleanId === VIRTUAL_SERVER_ENTRY) return RESOLVED_SERVER_ENTRY;
if (cleanId === VIRTUAL_CLIENT_ENTRY) return RESOLVED_CLIENT_ENTRY;
Expand Down