fix(zone_cache_variants): use MarshalRoot for updates#6819
Open
sjparkinson wants to merge 4 commits intocloudflare:nextfrom
Open
fix(zone_cache_variants): use MarshalRoot for updates#6819sjparkinson wants to merge 4 commits intocloudflare:nextfrom
MarshalRoot for updates#6819sjparkinson wants to merge 4 commits intocloudflare:nextfrom
Conversation
Author
|
Thanks for running the tests, I'll dig into the failure. Ah missed including the new fixture! f180900 should resolve it. |
15e2351 to
f180900
Compare
cc2f02a to
94b9515
Compare
db5b37e to
34540ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
zone_cache_variantsresource by not including removed variants in the request body.Acceptance test run results
Steps to run acceptance tests
Test output
Additional context & links
Fixes #6700.
I used a similar approach to the fix in the
custom_hostnameresource1.Footnotes
https://github.com/cloudflare/terraform-provider-cloudflare/blob/b44cf8a64c5152a76094cc0844e6f02da8000556/internal/services/custom_hostname/model.go#L35-L44 ↩