Restyled the theme switcher in the nav to a switch rather than a button for improved UX#173
Draft
AlexanderChernyshev wants to merge 1 commit intocloudflare:mainfrom
Draft
Conversation
…on for improved UX
sergeychernyshev
requested changes
Mar 4, 2026
Member
sergeychernyshev
left a comment
sergeychernyshev
left a comment
There was a problem hiding this comment.
Looks like server-side rendering for the switch is not working, it only switches when JS kicks in.
Member
|
It might be a good idea to try to see if it can use radio buttons and apply CSS based on the value of a button rather than a class on the :root element which would allow the switch to work without JS at all. You will still need to set the cookie using JS when it loads though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the theme switcher element in the top-nav from a button to a switch to improve UX by adjusting the design to be intuitive to the user. This way it is clearer what change will happen when "throwing" the switch without the user needing to interact with it.
Changes were made with the assistance of Google's Gemini AI.