Provides device emulation via --deviceName flag using playwright#132
Provides device emulation via --deviceName flag using playwright#132
Conversation
f35be5a to
9fd0cd9
Compare
|
Hey @MildMax, can you update the PR description with what else you did in this PR (I see that you upgraded playwright - was it needed for something specific?). Also, can you link the issue in this PR as well? |
|
I also see extra space, please run the |
sergeychernyshev
left a comment
There was a problem hiding this comment.
All looks great and straightforward with just a couple comments.
Still getting
Jest did not exit one second after the test run has completed.
'This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.
__tests__/emulation.test.ts
Outdated
| @@ -0,0 +1,135 @@ | |||
| import fs from 'fs'; | |||
| import { launchTest, SuccessfulTestResult } from '../src/index.js'; | |||
There was a problem hiding this comment.
My TypeScript complains that SuccessfulTestResult is only used for types and should be imported separately as such.
I got the same thing with jest and that's about it |
I'm no longer getting this timeout warning |
88e7cd9 to
0e4aa7a
Compare
…ext in createBrowser
ca88ad8 to
431f1c8
Compare
… what 'device' is in options and config contexts
…ng device emulation
…est ID in tmp folder
|
moved to draft and paused due to issues with hanging processes when emulating devices on chromium based browsers |
Closes #4