fix(CommandPalette): fix demo items not rendering and font size#175
Merged
mattrothenberg merged 3 commits intomainfrom Mar 4, 2026
Merged
fix(CommandPalette): fix demo items not rendering and font size#175mattrothenberg merged 3 commits intomainfrom
mattrothenberg merged 3 commits intomainfrom
Conversation
- Add missing items={group.items} prop to CommandPalette.Group in demos
- Add text-base class to Item component for consistent 14px font size
- Add client-side filtering to demos so search actually filters results
The items prop was never added to the demos (bug since initial commit),
causing groups to render without their items. The Item component also
lacked an explicit font size, inheriting browser default 16px instead
of the intended 14px (text-base).
commit: |
Contributor
Docs PreviewCommit: |
geoquant
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
itemsprop on Group)text-baseclass)Details
Items not rendering: The
items={group.items}prop was never added toCommandPalette.Groupin the demos - this bug existed since the initial commit. Without it,Autocomplete.Collectionhas no items to render.Font size: The
Itemcomponent didn't specify a font size, so it inherited the browser default (16px) instead of using kumo'stext-base(14px).ResultItemalready hadtext-baseexplicitly set.Filtering: Demos now pre-filter groups/items client-side before passing to the component, matching how Stratus handles filtering.