cgroup_id_map: change example for CGRP_STORAGE to not use GET_F_CREATE#570
Open
dqminh wants to merge 1 commit intocloudflare:masterfrom
Open
cgroup_id_map: change example for CGRP_STORAGE to not use GET_F_CREATE#570dqminh wants to merge 1 commit intocloudflare:masterfrom
dqminh wants to merge 1 commit intocloudflare:masterfrom
Conversation
BPF_LOCAL_STORAGE_GET_F_CREATE will create a zero entry if it does not find our cgroup in the CGRP_STORAGE. THis is unnecessary work as the entry should only be written by ebpf_exporter for cgroups that we are interested in, so we should not set the flag.
Contributor
netoptimizer
left a comment
netoptimizer
left a comment
There was a problem hiding this comment.
Further down you are using the value stored in *ok to select which map to update.
Thus, the BPF_LOCAL_STORAGE_GET_F_CREATE is correctly used here.
Contributor
|
Have you seen: netoptimizer#1 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BPF_LOCAL_STORAGE_GET_F_CREATE will create a zero entry if it does not find our cgroup in the CGRP_STORAGE. THis is unnecessary work as the entry should only be written by ebpf_exporter for cgroups that we are interested in, so we should not set the flag.