[DLP] Add missing predefined detection entries#30648
Merged
caley-b merged 4 commits intocloudflare:productionfrom May 7, 2026
Merged
[DLP] Add missing predefined detection entries#30648caley-b merged 4 commits intocloudflare:productionfrom
caley-b merged 4 commits intocloudflare:productionfrom
Conversation
warnessa
requested review from
a team,
Maddy-Cloudflare and
codyanthony850
as code owners
caley-b
reviewed
May 6, 2026
| | Australia Business (ABN) | Detects Australian Business Numbers (ABN) such as "51 824 753 556". | | ||
| | Australia Company (ACN) | Detects Australian Company Numbers (ACN) such as "001 000 004". | | ||
| | Australia Medicare | Detects Australian Medicare card numbers such as "2000000006". | | ||
| | Australia Passport | Detects Australian passport numbers such as "L1234567". | |
Contributor
There was a problem hiding this comment.
This appears to be a somewhat duplicated line as line 31 ("AU Passport Number | Detects Australian passport numbers..."). Should we consider removing this new one and updating the original line instead?
Contributor
Author
There was a problem hiding this comment.
yes it's a duplicate however it's also a duplicate in the code lol. I will remove it once eng decides which detection we'll keep!
| | Germany VAT | Detects German VAT numbers (USt-IdNr) such as "DE100000003". | | ||
| | GitHub PAT | Detects GitHub personal access tokens such as a token beginning with `ghp_`. | | ||
| | Go | Detects Go source code. | | ||
| | Google GCP API Key | Detects Google Cloud Platform API keys such as "AIzaSyDaGmWKa4JsXZ-HjGw7ISLn_3namBGewQe". | |
Contributor
There was a problem hiding this comment.
The example API key, while a documented example from Google, sets off API key security alerts for us in Github. Would you be open to using something like "AIzaSyA-FAKE-KEY-FOR-DOCS-ONLY-000000" instead?
Contributor
Author
There was a problem hiding this comment.
updated description to use AIza<API_KEY>
warnessa
force-pushed
the
dlp-predefined-detection-entries-clean
branch
from
ca4a771 to
f23cbc9
Compare
caley-b
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Names (CA/US)withFull Nameand adding the US-prefixed driver's license and mailing address entries