Closed
Conversation
* Add events task-received, task-succeded and task-started * Format to follow black formating
Owner
I think this is based on #34? |
clokep
reviewed
Oct 2, 2023
clokep
reviewed
Oct 2, 2023
Owner
|
I think this needs a rework -- the tests don't seem to quite make sense to the code changes. If you're still interested in working on it, let me know and we can reopen. |
Author
|
I might take a look at some point, but I managed to do a workaround using an uglier solution for now (that is outside of this repo scope). It won't stand longterm but works for now. Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following preceding works (not updated since), I do this PR to add the following modifications
I intend (with your help if possible) to implement at least
task-failedandtask-retriedevents as well.