-
Notifications
You must be signed in to change notification settings - Fork 965
Add useOrganizationCreationDefaults to create organization custom flows guide
#3007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useOrganizationCreationDefaults to create organization custom flows guide
#3007
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Waiting on clerk/javascript#7690 to get merged first |
9204efe to
bbef4a4
Compare
|
We still have to release the clerk-js changes in case you'd like to test in production, but I've opened the PR already to get a review on the copy |
bbef4a4 to
6ec7580
Compare
|
left a review to use a partial for the duplicated code between the hook reference guide and the custom flow. other than that, i'd like sarah to update the "related sources" section as she recently did work across the docs related to that. |
Have revamped the "Related guides" sections and made them consistent: Make next steps consistent. Will review the rest of the PR @LauraBeatris! |
|
Okay have got two things I've noticed @alexisintech:
|
|
Also, I've realized we can bring the parameters and returns from Typedoc like the other hooks, so made a PR in javascript to make that happen. And then got this commit to use the Typedoc output. @LauraBeatris @alexisintech |
ahh very good catch!! yes let's fix for sdk specificity |
Okay have pushed a commit for point number 2.
Will think of how to tackle point number 1. |
|
Here is what I did for point 2: Add SDK specificity. Let me know what you guys thin @alexisintech @LauraBeatris |
|
i think that looks great, sarah, thank you i've also added setting the created org as the active org as i feel like that's an important step in the org creation process that we should show users how to do! |
alexisintech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfection 😸💖
|
@LauraBeatris oh wait, is this for core-2 or core-3? if it's for core-3, we need to change the base branch to the core-3 branch! |
@alexisintech This hook is in both core 2 and core 3 |
then i think this is good to merge, when you're ready :) |





🔎 Previews:
What does this solve?
Resolves ORGS-1263
Introduces
useOrganizationCreationDefaultshook to the custom flow guides for managing organizations