Skip to content

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jan 28, 2026

@LauraBeatris LauraBeatris self-assigned this Jan 28, 2026
@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-docs Ready Ready Preview Feb 3, 2026 6:09pm

Request Review

@LauraBeatris
Copy link
Member Author

Waiting on clerk/javascript#7690 to get merged first

@LauraBeatris
Copy link
Member Author

We still have to release the clerk-js changes in case you'd like to test in production, but I've opened the PR already to get a review on the copy

@LauraBeatris LauraBeatris marked this pull request as ready for review January 28, 2026 22:21
@LauraBeatris LauraBeatris requested a review from a team as a code owner January 28, 2026 22:21
@LauraBeatris LauraBeatris force-pushed the laura/update-custom-flows-docs-org-creation-defaults branch from bbef4a4 to 6ec7580 Compare January 28, 2026 22:23
@alexisintech alexisintech self-assigned this Jan 28, 2026
@alexisintech
Copy link
Member

left a review to use a partial for the duplicated code between the hook reference guide and the custom flow. other than that, i'd like sarah to update the "related sources" section as she recently did work across the docs related to that.
once that's done, i'm sure she will give you an approval 😸💖 thanks laura!!! great work on the docs here, thanks for adding all those sdk examples

@SarahSoutoul
Copy link
Contributor

left a review to use a partial for the duplicated code between the hook reference guide and the custom flow. other than that, i'd like sarah to update the "related sources" section as she recently did work across the docs related to that. once that's done, i'm sure she will give you an approval 😸💖 thanks laura!!! great work on the docs here, thanks for adding all those sdk examples

Have revamped the "Related guides" sections and made them consistent: Make next steps consistent. Will review the rest of the PR @LauraBeatris!

@SarahSoutoul
Copy link
Contributor

Okay have got two things I've noticed @alexisintech:

  1. When selecting any SDKs that isn't included in the custom flow components, this is how it appears. I'm not sure if this is what we want, or we may a default Next.js example to be showing when one is on the Express SDK for e.g.

    Screenshot 2026-01-29 at 5 11 18 pm
  2. Now that the custom flow uses two different hooks, think we can simplify the intro to be less redundant with "The following example" being used twice. Happy to revamp it if you'd like @LauraBeatris but interested to get your thoughts on the first point.

Screenshot 2026-01-29 at 5 05 40 pm

@SarahSoutoul
Copy link
Contributor

SarahSoutoul commented Jan 30, 2026

Also, I've realized we can bring the parameters and returns from Typedoc like the other hooks, so made a PR in javascript to make that happen. And then got this commit to use the Typedoc output. @LauraBeatris @alexisintech

@alexisintech
Copy link
Member

Okay have got two things I've noticed @alexisintech:

  1. When selecting any SDKs that isn't included in the custom flow components, this is how it appears. I'm not sure if this is what we want, or we may a default Next.js example to be showing when one is on the Express SDK for e.g.
    Screenshot 2026-01-29 at 5 11 18 pm
  2. Now that the custom flow uses two different hooks, think we can simplify the intro to be less redundant with "The following example" being used twice. Happy to revamp it if you'd like @LauraBeatris but interested to get your thoughts on the first point.
Screenshot 2026-01-29 at 5 05 40 pm

ahh very good catch!! yes let's fix for sdk specificity

@SarahSoutoul
Copy link
Contributor

Remove duplication of following example

Okay have pushed a commit for point number 2.

Screenshot 2026-01-30 at 2 47 58 pm

Will think of how to tackle point number 1.

@SarahSoutoul
Copy link
Contributor

Here is what I did for point 2: Add SDK specificity. Let me know what you guys thin @alexisintech @LauraBeatris

@alexisintech
Copy link
Member

i think that looks great, sarah, thank you

i've also added setting the created org as the active org as i feel like that's an important step in the org creation process that we should show users how to do!

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfection 😸💖

@alexisintech
Copy link
Member

@LauraBeatris oh wait, is this for core-2 or core-3? if it's for core-3, we need to change the base branch to the core-3 branch!

@LauraBeatris
Copy link
Member Author

@LauraBeatris oh wait, is this for core-2 or core-3? if it's for core-3, we need to change the base branch to the core-3 branch!

@alexisintech This hook is in both core 2 and core 3

@alexisintech
Copy link
Member

@LauraBeatris oh wait, is this for core-2 or core-3? if it's for core-3, we need to change the base branch to the core-3 branch!

@alexisintech This hook is in both core 2 and core 3

then i think this is good to merge, when you're ready :)

@LauraBeatris LauraBeatris merged commit 127c8f6 into main Feb 4, 2026
8 checks passed
@LauraBeatris LauraBeatris deleted the laura/update-custom-flows-docs-org-creation-defaults branch February 4, 2026 10:18
@SarahSoutoul SarahSoutoul self-assigned this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants