-
Notifications
You must be signed in to change notification settings - Fork 964
Add heading prop support and improve mobile SDK scoping #2992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds a new ManifestHeading type to support items with `heading: true` that act as section headers without an href. Also fixes SDK filtering errors by removing android/ios conditionals from pages under the Guides section which doesn't include those SDKs. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix copy-paste error: Android User Management now correctly links to /docs/reference/android/user instead of iOS path - Add frontmatter SDK to SDK computation for manifest items to better reflect document capabilities - Clarify SDK scoping precedence: explicit group SDK restrictions are now preserved even if children support more SDKs - Update comments to explain SDK logic for cases like Mobile Navigation section
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add iOS reference docs from mike/ios-v1-docs branch: auth, clerk, configuration, installation, organizations, user - Add Android auth.mdx from sam/android-v1-auth-reference branch - Create docs/reference/android/todo.mdx placeholder for missing Android docs - Update manifest to point missing Android docs to the todo placeholder
- Add iOS quickstart guide - Update 12 custom flow guides with iOS support - Update reference view docs (auth-view, user-button, user-profile-view) - Update iOS overview and remove deprecated get-token.mdx - Update manifest: remove iOS getToken entry, point Android auth to todo placeholder
- Add installation.mdx with Gradle setup instructions - Add configuration.mdx with Clerk.initialize() pattern - Add clerk.mdx with reactive state flows (Clerk.userFlow, Clerk.isInitialized) - Add user.mdx for user management methods - Add organizations.mdx for organization management - Update auth.mdx to use Clerk.auth (uppercase) consistently - Update manifest.json to point to new Android reference pages Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
468c363 to
b3209db
Compare
8541e4c to
72a3ea7
Compare
671ad5c to
5d3aec8
Compare
Co-Authored-By: Claude Opus 4.5 <[email protected]>
5d3aec8 to
1c03464
Compare
db2557a to
279aad4
Compare
279aad4 to
bd267e6
Compare
bd267e6 to
9f8ee96
Compare
|
Have pushed a final docs review after reviewing more closely the content. That review mostly focuses on consistency when comparing the different variants (iOS vs Android). One thing I did notice is that for the
Also left a separate comment for you @swolfand here: #2992 (comment). Tagging you @manovotny @alexisintech for visibility. |
|
|
||
| **Users can only create passkeys after signing up**, so you'll need to enable another authentication strategy for the sign-up process. After signing in, users can create a passkey. | ||
|
|
||
| <If sdk="android"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| **Users can only create passkeys after signing up**, so you'll need to enable another authentication strategy for the sign-up process. After signing in, users can create a passkey. | ||
|
|
||
| <If sdk="android"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And did the same for the social connections apple guide: Refinements
| ```kotlin | ||
| dependencies { | ||
| // For prebuilt UI components (includes API) | ||
| implementation("com.clerk:clerk-android-ui:1.0.0") | ||
|
|
||
| // Or for API only (no UI) | ||
| implementation("com.clerk:clerk-android-api:1.0.0") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things on this @swolfand:
-
In the quickstart, we also import the Lifecycle ViewModel Compose Library:
implementation("androidx.lifecycle:lifecycle-viewmodel-compose:2.9.2"). Is it needed here too? -
The version for both of these imports is
1.0.0, but that might change no? Do we want to have<latest-version>instead like we do in the Quickstart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- for the first I think this is just installation of the clerk sdks, not doing the quickstart,
- Yes! will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch @SarahSoutoul! Sam's is correct here. I'll get iOS updated to match. |




Warning
Depends on https://github.com/clerk/clerk/pull/2018, which must be merged first.
Previews
What does this solve?
ManifestHeadingtypeWhat changed?
ManifestHeadingtype to support section headings with SDK scoping