Fix: New Maven provider: Clojars#1557
Open
shahyashish wants to merge 1 commit intoclearlydefined:masterfrom
Open
Fix: New Maven provider: Clojars#1557shahyashish wants to merge 1 commit intoclearlydefined:masterfrom
shahyashish wants to merge 1 commit intoclearlydefined:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed by GitFix AI Agent.
I have added 'clojars' to the
toLowerCaseMapwith theNAMESPACE | NAMEbitwise flags. This ensures that coordinates for artifacts from the Clojars repository are correctly normalized to lowercase for both the namespace (groupId) and name (artifactId), which is the standard behavior for Maven-compatible providers in the ClearlyDefined ecosystem where case-insensitivity is common for lookups.Test: Verify by creating a new EntityCoordinates instance:
new EntityCoordinates('maven', 'Clojars', 'Org.Clojure', 'Clojure', '1.10.1'). The resulting instance should have: 1.providerset to 'clojars' (lowercase), 2.namespaceset to 'org.clojure' (lowercase), 3.nameset to 'clojure' (lowercase). Finally, callingtoString()should produce 'maven/clojars/org.clojure/clojure/1.10.1'.