Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8431 +/- ##
==========================================
- Coverage 88.91% 88.90% -0.02%
==========================================
Files 286 286
Lines 63103 63103
Branches 7908 7908
==========================================
- Hits 56110 56100 -10
- Misses 4735 4739 +4
- Partials 2258 2264 +6 🚀 New features to boost your workflow:
|
e1f8bc6 to
6a27d5c
Compare
0a86a6b to
723789d
Compare
d6e1c53 to
b44d601
Compare
added 9 commits
February 6, 2026 15:44
0642595 to
edf377e
Compare
onurctirtir
approved these changes
Feb 10, 2026
Member
There was a problem hiding this comment.
LGTM, optionally, we can make CI happier by adding this into multi_name_resolution.sql
SET client_min_messages TO WARNING;before the following line
DROP SCHEMA multi_name_resolution CASCADE;Also, I got confused a bit - won't we add a workflow that can be manually triggered via Actions tab within this PR? Sth that takes Citus version and "n-1 mode" to test against as inputs?
--
Also, it'd be nicer if we can document how to run those tests locally / on CI in src/test/regress/README.md etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for running regression tests in mixed‑version scenarios
This PR updates the regression test runner script, test schedules, and some regression tests to support running Citus in mixed‑version setups.
With these changes, regression test schedules can be executed in N/N‑1 and mixed‑version scenarios, including:
For potential usage, see the workflow jobs removed in commit (0642595) and the corresponding test runs at (https://github.com/citusdata/citus/actions/runs/20746079664).
Details
Schedule refactoring
To enable N‑1 testing for the remaining multi‑node tests, this PR separates tests that drop/create the Citus extension from the existing multi_1_schedule into a new schedule
multi_1_create_citus_scheduleThis allows the remaining multi‑node tests to be reused safely in N‑1 scenarios.
Test changes
Perl script changes
This PR extends src/test/regress/pg_regress_multi.pl to support:
These changes enable running N/N‑1 compatibility tests in multiple configurations. Sample scenarios are listed below.
Sample scenarios
To demonstrate potential usage sample jobs are added to git workflow but excluded from this PR (see previous comment on the commit and runs).
Test Citus Lib N‑1
All nodes load citus.so from version 13.2.
Test Citus SQL N‑1
All nodes create the Citus extension at version 13.2‑1.
Test Citus Worker N‑1
Only worker 1 loads citus.so from 13.2 and creates the extension at 13.2‑1.
Test Citus Coordinator N‑1
Only the coordinator loads citus.so from 13.2 and creates the extension at 13.2‑1.
Note that the following schedules from “Test Citus” are not included in N‑1 scenarios:
check-multi-1-create-citus, check-multi-mxSome tests in these schedules drop and recreate the Citus extension using the default version, which is incompatible with N‑1 setups.check-vanillaThe test preparation steps have not yet been adapted for N‑1 workflows.Local testing
Local testing can be performed using sql/versions.sql and test_versions.sh. (removed in previous commit)
Steps:
See version_test_results.txt for example results.
Sample test runs:
CITUSLIBDIR=~/citus-libs/17/v13.2.0 CITUSVERSION=13.2-1 N1MODE=workeronly EXTRA_TESTS=versions make check-minimal
CITUSVERSION=13.2-1 N1MODE=all EXTRA_TESTS=versions make check-minimal