Skip to content

Comments

New python 3 asyncio backend#70

Open
cr0hn wants to merge 4 commits intocircus-tent:masterfrom
cr0hn:master
Open

New python 3 asyncio backend#70
cr0hn wants to merge 4 commits intocircus-tent:masterfrom
cr0hn:master

Conversation

@cr0hn
Copy link

@cr0hn cr0hn commented Mar 29, 2015

An intent to add a backend based on asyncio python 3 frameworks, through aiohttp-wsgi module.

cr0hn added 2 commits March 29, 2015 16:30
…-wsgi module. aiohttp-wsgi module need accept a pull request sent to accept some new features to be compatible with chaussete
…-wsgi module. aiohttp-wsgi module need accept a pull request sent to accept some new features to be compatible with chaussete

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this print statement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace it with pass as above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oks!

@douardda
Copy link

The 2 changesets in this PR must be folded.

cr0hn added 2 commits June 15, 2015 13:10
removed print statement
Removed dict as a parameter.
@douardda
Copy link

Looks nice, but could you please:

  • modify the chaussette/tests/test_backend.py to ensure your backend is tested
  • rebase your branch on current master (to keep git history clean)
  • squash (fold) the commits (again, keep the history clean),
  • ensure aiohttp_wsgi is properly handled in the setup.py and tox.ini files
  • add yourself in the THANKS file

Humm I guess that should be enough ;-) Thanks!

David

@jacobsvante
Copy link

This would be a great addition to the backend list!

@golem131
Copy link

and when?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants