Remove ember-source and glimmer tracking as a peer dependency#1877
Merged
mkszepp merged 1 commit intocibernox:masterfrom May 10, 2025
runspired:master
Merged
Remove ember-source and glimmer tracking as a peer dependency#1877mkszepp merged 1 commit intocibernox:masterfrom runspired:master
mkszepp merged 1 commit intocibernox:masterfrom
runspired:master
Conversation
Contributor
runspired
commented
May 10, 2025
runspired
commented
- @glimmer/tracking is provided by ember-source
- ember-source is assumed by both embroider and ember-cli in ways that it doesn't actually need to be a peer, and having it as one creates potential for duplicate copies that create errors in apps
Collaborator
|
Here more details, why we should do |
mkszepp
changed the title
mkszepp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.