(#282) Allow building with the latest SSMS installed.#283
Draft
corbob wants to merge 2 commits intochocolatey:developfrom
Draft
(#282) Allow building with the latest SSMS installed.#283corbob wants to merge 2 commits intochocolatey:developfrom
corbob wants to merge 2 commits intochocolatey:developfrom
Conversation
Member
|
@corbob our futureselves are going to want/need more words in the commit message than that! 😄 |
Member
Author
@gep13 I know that 🤪 Current me was just getting things up while I was waiting for a packer build to finish! But tomorrow me is a future me that will likely want more information, so thank you very much for the nudge today while I have some of the information in my head 👍 |
This commit updates the logic for detecting the MSBuild tool. Our builds encountered this issue: NuGet/Home#14349. While investigating it, it was found that dnnsoftware encounted a similar issue and fixed it here: dnnsoftware/Dnn.Platform#6575. This commit updates the methods we use to call VSWhere to identify the MSBuild to return based on actually having an MSBuild.exe file.
I've found a better way to do local development on the recipe, so this updates the Readme with that information.
e740529 to
dbb160b
Compare
Member
Author
|
This is draft while I work through any details needed here... It's also possible that this is no longer an issue once Visual Studio 2026 is installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the logic to find an MSBuild that actually has an MSBuild?
Motivation and Context
Being able to build things while the latest SSMS is installed.
Testing
For any project using this recipe, apply a similar diff to this:
Run the build script.
Operating Systems Testing
Windows 11
Change Types Made
Change Checklist
Related Issue