[WIP] remove 1px gray line in bg2 + use scale(1.12) for minimized error#1
Open
bsansouci wants to merge 1 commit intochenglou:masterfrom
Open
[WIP] remove 1px gray line in bg2 + use scale(1.12) for minimized error#1bsansouci wants to merge 1 commit intochenglou:masterfrom
bsansouci wants to merge 1 commit intochenglou:masterfrom
Conversation
It seems like chrome does some rounding here and it makes a grey line appear at the top of the card. It's more visible on non-retina monitors. This plays with the rounding and makes the issue much less visible.
Author
|
It doesn't affect safari. But it does affect the size of the card (of course), your call if this is acceptable. |
bsansouci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like chrome does some rounding here and it makes a grey line
appear at the top of the card. It's more visible on non-retina monitors.
This plays with the rounding and makes the issue much less visible.
Before:
After:
