fix: do not treat a NodeList as HTMLCollection

[DiogoDoreto]

An HTMLCollection assumes all items are Elements, a NodeList however may also include Nodes such as Text and Comment, which does not include the getAttributeNames method.

Stops the error described here chaijs/chai#1680 but logging that div from inside the iframe changes the output a bit, logging it as a regular object ( HTMLDivElement{ …(1) } ), but in a way that is still acceptable to me for now, until we wait for the proper fix described here: chaijs/chai#1680 (comment)

[DiogoDoreto]

Hi @43081j , would this simple fix be acceptable to you?

[keithamus]

I think I'd prefer to see more work done in inspectHTML to switch on the node type. inspectHTML should probably be typed so that the first argument is instead node: Node and follow on from there.

[43081j]

main...node-lists-and-such

something like this was what i had in mind

sorry i didnt give you chance to try write this yourself, i didn't know the answer until i started hacking away at it

we can pull this into your PR here if we're all happy with it

[DiogoDoreto]

@43081j no worries, your solution is better than mine. My goal was just to prevent the error, and I'm happy to see this moving forward. Thanks for your time :)

[DiogoDoreto]

@43081j just placed your changes within my previously failing tests and it's all good

[43081j]

@keithamus let me know what you think and ill push it to this branch if all is good

@DiogoDoreto thanks for reviewing 🙏

[keithamus]

Looks good but I think perhaps all inspectList calls in the html.ts file should use inspectNode, no?

[43081j]

you're right, i've simplified it by removing the HTMLCollection stuff entirely and using inspectNodeCollection for both

[43081j]

i've merged my changes into this branch

@keithamus if you can re-review, we can probably merge this

[keithamus]

Okay I think this looks good. We should probably add some more tests but can follow up with that.