Conversation
Collaborator
Author
|
Let's not merge this until 7.21 is out; --> draft |
robertc2000
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
atcmd.{c,h}- This driver also sends the HDLC idle (start/stop) flags. This can be easily configured out in the future, byte stuffing/unstuffing has a configuration switch to disable them now.l2_ppp.{c,h}. There, reusable portions are moved to internal functions and support for PPPoE is added.ppp.{c,h}driverl2types:MG_TCPIP_L2_PPPandMG_TCPIP_L2_PPPoEdriver_ready. The driver is handled by net_builtin, driver link state is updated every second. This updated state is recorded atifp->driver_ready. Any L2 function can then now if its physical link or underlying layer is ready or not.NOTE: statics should move into a struct mg_l2_ppp_data, referenced through void * ifp->l2data