nfs: add snapshot-backed (shallow) read-only volume support#6193
Draft
Rakshith-R wants to merge 1 commit intoceph:develfrom
Draft
nfs: add snapshot-backed (shallow) read-only volume support#6193Rakshith-R wants to merge 1 commit intoceph:develfrom
Rakshith-R wants to merge 1 commit intoceph:develfrom
Conversation
Remove the hardcoded `backingSnapshot = "false"` override in the NFS controller, enabling NFS volumes to use CephFS snapshot-backed (shallow) read-only volumes. This avoids expensive data cloning when read-only access to snapshot contents is needed. Changes: - Expose `backingSnapshotRoot` in CephFS volume context so the NFS controller can construct the correct export path pointing to the snapshot data directory. - Remove the `backingSnapshot` blocker in NFS CreateVolume and adjust the NFS export path to include the backing snapshot root for snapshot-backed volumes. - Add three NFS e2e tests: snapshot-backed volume, backing snapshot as false, and RWX clone from ROX PVC. Co-Authored-By: Claude <[email protected]> Signed-off-by: Rakshith R <[email protected]>
Contributor
Author
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
Contributor
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Remove the hardcoded
backingSnapshot = "false"override in the NFS controller, enabling NFS volumes to use CephFS snapshot-backed (shallow) read-only volumes. This avoids expensive data cloning when read-only access to snapshot contents is needed.Changes:
backingSnapshotRootin CephFS volume context so the NFS controller can construct the correct export path pointing to the snapshot data directory.backingSnapshotblocker in NFS CreateVolume and adjust the NFS export path to include the backing snapshot root for snapshot-backed volumes.