fix(mbi): fix ONLY_FULL_GROUP_BY issues in Gorgone ETL Perl modules#3336
Open
fix(mbi): fix ONLY_FULL_GROUP_BY issues in Gorgone ETL Perl modules#3336
Conversation
MON-198038 The Gorgone ETL Perl modules have the same ONLY_FULL_GROUP_BY issues as the ones fixed in MON-196670 for the centreon-modules ETL modules. - BIMetric.pm: add missing s.service_id to GROUP BY - MetricDailyValue.pm: wrap first_value, last_value, total in MAX() instead of leaving them as bare non-aggregated columns - Metrics.pm: wrap d.value, d2.value in MAX() instead of adding them to GROUP BY (which changed query semantics)
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: MON-198038
The Gorgone ETL Perl modules have the same ONLY_FULL_GROUP_BY issues as the ones fixed in
centreon-modules#7716 for the centreon-modules ETL modules.
s.service_idto GROUP BY ininsertMetricsIntoTablefirst_value,last_value,totalin MAX() aggregates instead of leaving them as bare non-aggregated columnsd.value,d2.valuein MAX() instead of adding them to GROUP BY (which changed query semantics); simplify GROUP BY back to justdb.id_metricType of change
Target serie
How this pull request can be tested ?
Run MBI ETL with MySQL
ONLY_FULL_GROUP_BYenabled. Verify that:insertMetricsIntoTable) succeeds without SQL errorsgetMetricCapacityValuesOnPeriod) return correct first/last values per metricgetFirstAndLastValues) returns one row per metricChecklist
Summary by Aikido
🐛 Bugfixes
More info