Skip to content

Comments

Run tests against main ruby 3.4 release#455

Merged
santiagorodriguez96 merged 1 commit intomasterfrom
sr--run-ci-with-ruby-3.4
Feb 14, 2025
Merged

Run tests against main ruby 3.4 release#455
santiagorodriguez96 merged 1 commit intomasterfrom
sr--run-ci-with-ruby-3.4

Conversation

@santiagorodriguez96
Copy link
Contributor

No description provided.

@nicolastemciuc
Copy link
Member

What do you think about running rubocop using Ruby 3.4?

lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
bundler-cache: true
- run: bundle exec rubocop -f github

@santiagorodriguez96
Copy link
Contributor Author

What do you think about running rubocop using Ruby 3.4?

lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
bundler-cache: true
- run: bundle exec rubocop -f github

Good call! Will open a different PR for that 🙂

@santiagorodriguez96 santiagorodriguez96 merged commit 797e8a6 into master Feb 14, 2025
11 checks passed
@santiagorodriguez96 santiagorodriguez96 deleted the sr--run-ci-with-ruby-3.4 branch March 11, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants