Skip to content

Added the case for reading blank cells as empty strings #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nikitapaliwal123 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Added the case for reading blank cells as empty strings #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5424f76
Added the case for reading blank cells as empty strings in place of '…
Nikitapaliwal123 Jan 16, 2023
dc40e08
Added the case for reading blank cells as empty strings in place of '…
Nikitapaliwal123 Jan 23, 2023
13a95ae
Added the case for reading blank cells as empty strings in place of '…
Nikitapaliwal123 Jan 24, 2023
21ead6b
Added the case for reading blank cells as empty strings in place of '…
Nikitapaliwal123 Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core-plugins/src/main/java/io/cdap/plugin/batch/source/ExcelInputReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public class ExcelInputReader extends BatchSource<LongWritable, Object, Structur
private static final String RECORD = "record";
private static final String EXIT_ON_ERROR = "Exit on error";
private static final String WRITE_ERROR_DATASET = "Write to error dataset";
private static final String NULL = "NULL";
private static final String NULL = "";
private static final String END = "END";
private static final String SHEET_NO = "Sheet Number";

Expand Down Expand Up @@ -204,7 +204,6 @@ public void transform(KeyValue<LongWritable, Object> input, Emitter<StructuredRe
if (columnValue.length > 1) {
String name = columnValue[0];
String value = columnValue[1];

if (columnMapping.containsKey(name)) {
excelColumnValueMap.put(columnMapping.get(name), value);
} else {
Expand Down
Binary file modified core-plugins/src/test/resources/civil_test_data_two.xlsx
View file
Open in desktop
Binary file not shown.