Upgrade Guava from 13.0.1 to 32.0.0-jre#81
Closed
AbhishekKumar9984 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the Guava dependency to version 32.0.0-jre and refactors the codebase to use standard Java APIs or updated Guava utilities. Key changes include replacing Guava's Charsets with java.nio.charset.StandardCharsets, migrating Guava's Objects to java.util.Objects or MoreObjects, and updating service lifecycle methods in tests. The reviewer pointed out that replacing Throwables.propagate(e) with new RuntimeException(e) changes the behavior for unchecked exceptions by wrapping them. It is recommended to use Throwables.throwIfUnchecked(e) before wrapping to ensure that RuntimeException and Error instances are rethrown without additional nesting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace removed APIs:
Throwables.propagate() -> throw new RuntimeException(e)
InputSupplier (removed) -> use existing ContentProvider
Charsets.UTF_8 -> StandardCharsets.UTF_8
Objects.toStringHelper/firstNonNull -> MoreObjects equivalents
Objects.hashCode -> java.util.Objects.hash
startAndWait/stopAndWait -> startAsync().awaitRunning/stopAsync().awaitTerminated
Update ASM bytecode generation to use RuntimeException constructor
Fix header ordering in HttpRequestsTestBase