Skip to content

✨ Added critical temperature domain simulation#82

Open
Drewniok wants to merge 2 commits intomainfrom
add_temperature_domain
Open

✨ Added critical temperature domain simulation#82
Drewniok wants to merge 2 commits intomainfrom
add_temperature_domain

Conversation

@Drewniok
Copy link
Collaborator

Description

This PR addresses issue #20 by adding the critical temperature domain simulation. It can be chosen via a checkbox if the "normal" operational domain or the critical temperature one is wanted.

grafik

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Mar 14, 2025
@Drewniok Drewniok self-assigned this Mar 14, 2025
@Drewniok
Copy link
Collaborator Author

The clicked parameter point is shown when clicking on the operational domain plot. Should we add the critical temperature as a third entry when clicking on a point in the critical temperature plot, @marcelwa. I think it needs, however, some refactoring.

@marcelwa
Copy link
Collaborator

Thank you so much for the addition! 🙏 The entire code base needs some refactoring I fear 😅 Going through it currently just makes me awfully aware of how quickly it was put together 😬

@Drewniok
Copy link
Collaborator Author

@Drewniok, @marcelwa Add critical temperature domain to README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants