Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
…ned_gates_sorting # Conflicts: # include/fiction/algorithms/physical_design/design_sidb_gates.hpp
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/design_sidb_gates.hpp
Outdated
Show resolved
Hide resolved
Collaborator
|
@wlambooy is this PR still under active development, or can it be closed? |
Collaborator
Author
I actually started merging it with main yesterday (big task in this case). It is a good starting point for the advanced circuit design I'm getting into. I'll let you know if this PR will stay or if it will be part of a different one. |
Signed-off-by: GitHub Actions <[email protected]>
…ned_gates_sorting
Signed-off-by: GitHub Actions <[email protected]>
…ned_gates_sorting
include/fiction/algorithms/simulation/sidb/compare_by_ground_state_isolation.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/compare_by_ground_state_isolation.hpp
Show resolved
Hide resolved
6 tasks
Signed-off-by: Willem Lambooy <[email protected]>
Drewniok
reviewed
Jun 3, 2025
Collaborator
There was a problem hiding this comment.
could you make sure to use #if (FICTION_ALGLIB_ENABLED) where CC is used.
Collaborator
Author
There was a problem hiding this comment.
I actually do not see any uses. Did I miss something?
Collaborator
Author
There was a problem hiding this comment.
I double checked it again. There is only one removed mention of CLUSTERCOMPLETE. Please check if your comment still holds
# Conflicts: # bindings/mnt/pyfiction/include/pyfiction/algorithms/physical_design/design_sidb_gates.hpp # bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp # bindings/mnt/pyfiction/test/algorithms/physical_design/test_design_sidb_gates.py # bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_is_operational.py # include/fiction/algorithms/physical_design/design_sidb_gates.hpp # include/fiction/algorithms/simulation/sidb/is_operational.hpp
Signed-off-by: GitHub Actions <[email protected]>
…ned_gates_sorting
…ned_gates_sorting
…ned_gates_sorting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an extension to
is_operationalanddesign_sidb_gates. The former is now able to return the simulation results that certify the statusOPERATIONAL, which may then be used by the extension to the latter, which uses the simulation results to return the designed layouts in a specific ordering. This PR implements a simple heuristic for this ordering, namely it prefers the layouts for the the ground state isolation is large, ie., the energetic gap between the ground state and the first excited state. Specifically, it sorts by the minimum ground state isolation for each input.To use this new feature when designing SiDB gates, make sure that all combinations are enumerated, and set the
post_design_processparameter toPREFER_ENERGETICALLY_ISOLATED_GROUND_STATES.Checklist: