Fix undefined variable $title when rendering profile table#429
Open
kristian-94 wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
Open
Fix undefined variable $title when rendering profile table#429kristian-94 wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
kristian-94 wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
Conversation
674e6a6 to
1c4705a
Compare
Author
|
Hi @marxjohnson , let me know what you think about this, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
col_request() referenced an undefined $title variable when rendering the lock icon for locked profiles.
The test also shows the issue, without the fix:
One line fix, @brendanheywood , is this something you can review? Thank you!