Skip to content

Fix undefined variable $title when rendering profile table#429

Open
kristian-94 wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
kristian-94:bugfix/undefined-var
Open

Fix undefined variable $title when rendering profile table#429
kristian-94 wants to merge 1 commit intocatalyst:MOODLE_403_STABLEfrom
kristian-94:bugfix/undefined-var

Conversation

@kristian-94
Copy link
Copy Markdown

col_request() referenced an undefined $title variable when rendering the lock icon for locked profiles.

The test also shows the issue, without the fix:

vendor/bin/phpunit --testsuite tool_excimer_testsuite --filter tool_excimer_profile_table_test
Moodle 4.5.8+ (Build: 20260116), 3c33567cad20e60a8382ea3e9e3b1f59a4bde5f5
Php: 8.3.30, mysqli: 9.6.0, OS: Darwin 25.4.0 arm64
PHPUnit 9.6.29 by Sebastian Bergmann and contributors.

E                                                                   1 / 1 (100%)

Time: 00:00.314, Memory: 78.50 MB

There was 1 error:

1) tool_excimer\tool_excimer_profile_table_test::test_col_request_locked_profile_lock_icon_alt
Undefined variable $title

/Users/kristian/projects/ringertech/nsw-dep-edu/vetss-app-evidencecentral/admin/tool/excimer/classes/profile_table.php:297
/Users/kristian/projects/ringertech/nsw-dep-edu/vetss-app-evidencecentral/admin/tool/excimer/tests/tool_excimer_profile_table_test.php:90
/Users/kristian/projects/ringertech/nsw-dep-edu/vetss-app-evidencecentral/lib/phpunit/classes/advanced_testcase.php:76

ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

One line fix, @brendanheywood , is this something you can review? Thank you!

@kristian-94 kristian-94 force-pushed the bugfix/undefined-var branch from 674e6a6 to 1c4705a Compare April 24, 2026 02:46
@kristian-94
Copy link
Copy Markdown
Author

Hi @marxjohnson , let me know what you think about this, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant