Skip to content

50 graphviper changes needed for astroviper demonstrator #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jan-Willem merged 2 commits into from
Mar 5, 2026
Merged

50 graphviper changes needed for astroviper demonstrator #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc507bf
Fix graph building ipynb.
Jan-Willem Mar 5, 2026
793a128
black.
Jan-Willem Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
564 changes: 358 additions & 206 deletions docs/graph_building_tutorial.ipynb
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 7 additions & 5 deletions src/graphviper/graph_tools/coordinate_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ def make_parallel_coord(
parallel_coord["data_chunk_slices"] = data_chunk_slices
else:
raise ValueError("Exactly one of n_chunks and gap must be specified")

parallel_coord["dims"] = coord["dims"]
parallel_coord["attrs"] = coord["attrs"]
return parallel_coord
Expand Down Expand Up @@ -463,8 +463,6 @@ def string_interpolator(query_values, string_to_idx):
) # Nested Dict keys: task_id, [data_selection,chunk_indices,parallel_dims], xds_name, dim.

# Loop over every task node (each task node has a unique task_id):



task_id = 0
for partition in partition_map.keys():
Expand All @@ -486,8 +484,12 @@ def string_interpolator(query_values, string_to_idx):
]
chunk_coords["dims"] = parallel_coords[dim]["dims"]
chunk_coords["attrs"] = parallel_coords[dim]["attrs"]
chunk_coords["slice"] = parallel_coords[dim]["data_chunk_slices"][chunk_indices[i_dim]]

if "data_chunk_slices" in parallel_coords[dim]:
chunk_coords["slice"] = parallel_coords[dim]["data_chunk_slices"][
chunk_indices[i_dim]
]
else:
chunk_coords["slice"] = slice(None)
task_coords[dim] = chunk_coords

# breakpoint()
Expand Down
Loading