write YAML for ROS map_server#1834
Open
kingsimba wants to merge 3 commits intocartographer-project:masterfrom
Open
write YAML for ROS map_server#1834kingsimba wants to merge 3 commits intocartographer-project:masterfrom
kingsimba wants to merge 3 commits intocartographer-project:masterfrom
Conversation
kingsimba
force-pushed
the
yaml_for_ros_map_server
branch
from
86100f9 to
6f5c9ec
Compare
Signed-off-by: kingsimba <kingsimba0511@gmail.com>
kingsimba
force-pushed
the
yaml_for_ros_map_server
branch
from
6f5c9ec to
b794a9d
Compare
|
Hi @kingsimba , thank you for your contribution. can you please sign your commits? The easiest way is to use git commit --amend --no-edit --signoff. See https://github.com/cartographer-project/cartographer/blob/master/CONTRIBUTING.md for details. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm aware
cartographer_pbstream_to_ros_mapcan convert pbstream to PGM and YAML which can be fed into ROS map_serverBut the quality is obvious not as good as
cartographer_assets_writerbecause it doesn't use all the laser scans(scan accumulation).So, I modified
ProbabilityGridPointsProcessorto generate the YAML file.Related discussion also found on: cartographer-project/cartographer_ros#475