fix(codex): class-string is not contained by known string literals#1638
Merged
azjezz merged 1 commit intocarthage-software:mainfrom Apr 15, 2026
Merged
fix(codex): class-string is not contained by known string literals#1638azjezz merged 1 commit intocarthage-software:mainfrom
azjezz merged 1 commit intocarthage-software:mainfrom
Conversation
azjezz
added
c-codex
harutyundr
pushed a commit
to harutyundr/mago
that referenced
this pull request
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 What Does This PR Do?
Fixes a bug in the type comparator that caused
class-stringto be contained by known literal string types like'foo'.🔍 Context & Motivation
I found this while trying to figure out why this code wasn't working as expected: https://mago.carthage.software/playground#019d8d85-da2f-f6f4-9084-29849466e6e3
🛠️ Summary of Changes
📂 Affected Areas
🔗 Related Issues or PRs
None
📝 Notes for Reviewers
Claude Code was used to help author this change. New unit tests in
scalar_comparatorfollow the pattern set byarray_comparator.