Laravel Eloquent plugin#1261
Conversation
|
Ok, clippy should be happy now |
|
I'm refactoring the PHPantom implementation, splitting it up in multiple section. If you prefer I can rework the porting to bring over one part at a time, that should make it easier to review and test. https://github.com/AJenbo/phpantom_lsp/tree/main/src/virtual_members/laravel |
|
@AJenbo small changes would be better indeed. Otherwise, this PR will be open for weeks until i find the time to review the 5000 changes 😅 And given that i don't use laravel, it would take even more time as i would have to verify every little thing. |
|
Alright I will do that, at least your not flagging fundamental issues with how I'm trying to bring this over so that's a good start. |
|
I don't see any fundamental things i disagree with, but haven't really read it all. the resolved names passing to plugins and codebase metadata to filter hook are fine, could be useful to other plugins too. |
|
Does a plugin have to be merged into mago to be usable? Laravel should support plugins like this. |
|
currently no. we don't have external plugin support, but we will probably in the future, i think once the internal plugin API stabilizes, and we are sure it can cover everything we need/want. |
|
Thank you always. I'll wait. Until the day I can use it in Laravel. |
This is a port of my Laravel Eloquent module from https://github.com/AJenbo/phpantom_lsp (including 128 tests)
Hope it can serve as a starting point for solving #885
Test file:
Before:
After: