Conversation
Akatuoro
requested review from
chgeo,
renejeglinsky and
swaldmann
as code owners
|
There's definitely removed flickering in the outline compared to I just noticed on reload the flickering at the top bar is still there but now a bit more pronounced, maybe because of the removed |
Yes, I also noticed that and have been looking into it. It has been happening on the live capire site for me as well though, so not sure if it's worse now. We don't have any actual transition that we could put this Still, the transition on VPSwitchAppearance is definitely the culprit. When permanently setting the css, there's no flicker. But then also the switch animations don't work. Will try out a few things... |
|
Fixed the header flicker. I noticed some layout shift when reloading at arbitrary scroll positions -> will look into that. |
|
So... I just noticed that both the header flicker and the scroll behavior also appear on the official vitepress documentation 😆 |
renejeglinsky
left a comment
renejeglinsky
left a comment
There was a problem hiding this comment.
Funny that I'm the codeowner in that area. We should fix that ;)
Done. This was because of the changed |
The toggle is animated again when switching. I missed this character while cleaning up #2428 and did not notice the missing animation.
4 participants
Fixes impl-variant toggle behavior in regards to:
Good page for testing: http://localhost:5173/docs/guides/databases/postgres#deploy
Chrome Performance CLS: 0.01 -> 0.00