Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds keyboard support to Mir's WLCS (Wayland Conformance Test Suite) integration, enabling keyboard-related conformance tests. The implementation follows the established patterns used for pointer and touch device integration.
Changes:
- Adds FakeKeyboard implementation following the same pattern as FakeTouch
- Implements keyboard event synthesis (key down/up) using Mir's input synthesis APIs
- Bumps WLCS protocol version from 2 to 4 to enable keyboard interface support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/mir_test_framework/test_wlcs_display_server.cpp | Implements FakeKeyboard struct, keyboard event handlers (key_down/key_up/destroy), create_keyboard method with DeviceObserver synchronization, and updates WLCS version to 4 |
| include/test/miral/test_wlcs_display_server.h | Adds create_keyboard() method declaration to TestWlcsDisplayServer interface |
TICS Quality Gate✔️ PassedNo changed files applicable for TICS analysis quality gating. TICS / TICS / Run TICS analysis |
Contributor
Author
|
Looks like the latest version of WLCS with keyboard support is not packaged outside of Ubuntu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
How to test
cmake -B build && cmake --build buildbuild:./build/wlcs <path to mir>/build/lib/miral_wlcs_integration.so --gtest_filter=KeyboardTest*Checklist
Adequate documentation added(optional) Added Screenshots or videos