deps(go): bump github.com/ubuntu/authd from 0.5.6 to 0.5.7 in /authd-oidc-brokers in the minor-updates group #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spelling where the keyword is written in one word breaks code navigation in my IDE.
Using ${CURDIR} breaks code navigation in my IDE
The latter seems to be supported by robot framework but not by IDE.
It's hard to debug failures without the command output.
I encountered the issue that the port 5900 was already in use by another VM which caused the tests to fail. Let libvirt assign a free VNC port instead and tell YARF to use that port.
Arguments can now be passed to yarf after a `--`.
Note that yarf itself passes arguments to robot (the robot framework
executable) after a `--`, so we can now pass arguments to robot after
two `--`, for example:
e2e-tests/run_tests.sh -- -- --loglevel DEBUG
* Avoids reusing the same run dir each time, allowing to look at the results of previous runs * More easily discoverable since it's in the repo (but ignored in .gitignore to avoid untracked files).
... and a e2e-tests/vm/ssh.sh script to connect to the VM via SSH. The provisioning script does all the steps necessary before running the tests, including installation and configuration of authd and the brokers and creation of snapshots. We now use public key authentication when connecting to the VM via SSH, so the provisioning script requires an SSH public key as argument. Using public key authentication allows us to avoid using sshpass and is more secure, because it avoids that other libvirt VMs using the default network can access the e2e-runner.
We're using pipes in the script, and in general it's good practice to always set pipefail in bash scripts.
The script automates the setup of YARF for the end-to-end tests. It stores yarf in a gitignored directory which is automatically used by the run_test.sh script.
More descriptive variable name
Allows to debug the browser login via the webview. Replaces the functionality of the RUN_ONSCREEN environment variable.
We were frequently seeing errors like the password being pasted into the username field. Lets try to make this more robust by not only waiting for the page to stop loading but also for specific text to be visible.
So running the browser in any setup works with the the website defaults without making them translate
Avoid having to track the browser screenshots indexes manually
While here we should ideally just look for visible items, this is fine for now. However, we can make the check oneline and meanwhile we can ensure that the value we're looking is properly parsed, so dump it as JS and parse it back as such
Merge the previously independent authd-oidc-brokers repo as a subdirectory into the authd repo.
We already have these in the root directory of the monorepo.
Fixes fetching submodules to fail with:
/usr/bin/git submodule sync --recursive
/usr/bin/git -c protocol.version=2 submodule update --init --force --depth=1 --recursive
Error: fatal: No url found for submodule path 'authd-oidc-brokers/third_party/libhimmelblau' in .gitmodules
We want to do word splitting on flags
Fixes the libhimmelblau build to fail with:
current package believes it's in a workspace when it's not
* Remove surrounding $() to avoid executing output (or use eval if intentional). [SC2091] * Double quote array expansions to avoid re-splitting elements. [SC2068]
Same as for the qa workflow, see 768fd5a
Two reasons: * I couldn't get the version script to work when the snap/ directory was not in the git root directory, because it doesn't find the .git directory. * The Launchpad snap package requires a git branch which contains a top level snap/snapcraft.yaml.
It can happen that the version part is built twice:
execute action version:Action(part_name='version', step=Step.BUILD, action_type=ActionType.RUN, reason=None, project_vars=ProjectVarInfo(root={}), properties=ActionProperties(changed_files=None, changed_dirs=None))
[...]
execute action version:Action(part_name='version', step=Step.BUILD, action_type=ActionType.UPDATE, reason="'PULL' step changed", project_vars=ProjectVarInfo(root={}), properties=ActionProperties(changed_files=[], changed_dirs=['.git', 'snap']))
Both try to set the version, resulting in:
RuntimeError: 'override-build' in part 'version' executed an invalid control API call: variable 'version' can be set only once.
This commit only sets the version if it wasn't set before.
Rename
github.com/ubuntu/authd-oidc-brokers
to
github.com/canonical/authd/authd-oidc-brokers
We're merging the github.com/ubuntu/authd-oidc-brokers repo into the github.com/canonical/authd repo, so replace the links accordingly. Also, since "website" and "source-code" would point to the same URL, make "website" point to the documentation instead.
To make it more obvious that it do not contain the broker QA jobs.
Merge the previously independent authd-oidc-brokers repo as a subdirectory into the authd repo. The main motivation is that it allows the e2e-tests to test changes to the authd repo and the brokers repo at the same time. UDENG-8815
The "headings" in this list used inconsistent capitalization. They should use sentence case.
Bumps the minor-updates group in /authd-oidc-brokers with 1 update: [github.com/ubuntu/authd](https://github.com/ubuntu/authd). Updates `github.com/ubuntu/authd` from 0.5.6 to 0.5.7 - [Commits](v0.5.6...v0.5.7) --- updated-dependencies: - dependency-name: github.com/ubuntu/authd dependency-version: 0.5.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-updates ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Contributor
Author
|
Looks like github.com/ubuntu/authd is updatable in another way, so this is no longer needed. |
dependabot
bot
deleted the
dependabot/go_modules/authd-oidc-brokers/minor-updates-ed62ee8676
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the minor-updates group in /authd-oidc-brokers with 1 update: github.com/ubuntu/authd.
Updates
github.com/ubuntu/authdfrom 0.5.6 to 0.5.7Commits
938a2b8Add changelog entry for 0.5.7d5cb3a7debian/copyright: Add missing licensesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions