-
Notifications
You must be signed in to change notification settings - Fork 31
docs: Document how to configure authd for use with Keycloak #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d724096 to
d588d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Adrian. It's great to have this broker and use-case in the docs. Mostly minor suggestions, although I think a path needs to be fixed in one command.
It made me wonder should we add Keycloak and other Identity and Access Management tools that are supported through the OIDC broker to this reference page in the docs:
In that case, perhaps we would need to change the name from "cloud providers" to something more generic. Maybe a separate discussion and PR.
Another question is whether we should highlight the availability of the generic broker and the keycloak example on the homepage?
0ea9d31 to
a26e0d3
Compare
|
Thanks for the great review, as always!
Yes, I think we should! I pushed a commit which adds it to that doc and to the home page.
Agreed. I changed it to "identity provider" for now. What do you think about that? |
a26e0d3 to
7973efc
Compare
--- Sounds good to me @adombeck . |
edibotopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Excellent work.
We currently only document how to use the generic OIDC broker with Keycloak. Let's also explain on the install-authd page how to install the broker corresponding to Keycloak, for consistency. If we later want to document how to use other identity providers with the generic OIDC broker, we can add more tabs which also correspond to the authd-oidc broker.
... except when at the beginning of a sentence, then it's uppercase. That's how it's done in the snap documentation, so we should do the same.
It's the more technically correct term and also applies to Keycloak, which we now support and is not necessarily cloud-based.
7973efc to
19e9ee8
Compare
This adds documentation on how to use the generic OIDC broker with Keycloak.
UDENG-8809