Open
Conversation
…over then run install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry @ayakayorihiro, I stole your branch! A fork of #2603 which tries to reorganize some things and hopefully doesn't break everything?
I tried to break the dockerfile into a few more stages and took advantage of some dependencies having docker images available, namely the scala tooling and verilator. The latter slightly updated the version of verilator used since they didn't have an image for the version we have pinned. I picked the closest version after that.
Dahlia and Icarus now build in their own stages and are then just copied over. I couldn't figure out how to get TVM to build in its own stage without breaking things so for now that's still in the main image.
And I think I've fixed stuff such that it uses the proper uv environment, though some further tweaking may be necessary.