comb-prop: fix incorrect inlining that leaves wires undriven#2608
Open
Abhilekhgautam wants to merge 1 commit intocalyxir:mainfrom
Open
comb-prop: fix incorrect inlining that leaves wires undriven#2608Abhilekhgautam wants to merge 1 commit intocalyxir:mainfrom
Abhilekhgautam wants to merge 1 commit intocalyxir:mainfrom
Conversation
ekiwi
requested changes
Jan 20, 2026
Contributor
ekiwi
left a comment
ekiwi
left a comment
There was a problem hiding this comment.
This is a great start!
Can you try to add a test case that only works with this new pass? Maybe you can turn the example from the original issue into a test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2437