validate empty cache file by filesize#124
Open
mvenghaus wants to merge 1 commit intocalebporzio:mainfrom
Open
Conversation
Contributor
|
Nice! This is something I run into often. Particular if there is a timeout when the cache is being created the first time. I time myself having to "warm up" an app that I maintain, to ensure the cache file filled successfully and the sushi model is in an operable state. I tried to do it in the queue, it doesn't always workout. If someone tries visit the page at just the wrong moment when the cache is rebuilding it gets stuck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cache is enabled and the getRows method throws an exception, an empty database file is created. This file passes the exists and mtime checks and results in an error when the file is used the next time. You have do manually delete this file to fix it.